Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODULE_IMPORT_NS() changed to accept string literals in kernel 6.13 #39

Open
chrBrd opened this issue Jan 24, 2025 · 0 comments · May be fixed by #40
Open

MODULE_IMPORT_NS() changed to accept string literals in kernel 6.13 #39

chrBrd opened this issue Jan 24, 2025 · 0 comments · May be fixed by #40

Comments

@chrBrd
Copy link
Contributor

chrBrd commented Jan 24, 2025

Builds break with kernel 6.13 as MODULE_IMPORT_NS() has been changed to accept string literals instead of constants:

[   25s] gasket_page_table.c:57:18: error: expected ‘,’ or ‘;’ before ‘DMA_BUF’
[   25s]    57 | MODULE_IMPORT_NS(DMA_BUF);
[   25s]       |                  ^~~~~~~
[   25s] /usr/src/linux-6.13.0-1/include/linux/moduleparam.h:26:61: note: in definition of macro ‘__MODULE_INFO’
[   25s]    26 |                 = __MODULE_INFO_PREFIX __stringify(tag) "=" info
[   25s]       |                                                             ^~~~
[   25s] /usr/src/linux-6.13.0-1/include/linux/module.h:299:33: note: in expansion of macro ‘MODULE_INFO’
[   25s]   299 | #define MODULE_IMPORT_NS(ns)    MODULE_INFO(import_ns, ns)
[   25s]       |                                 ^~~~~~~~~~~
[   25s] gasket_page_table.c:57:1: note: in expansion of macro ‘MODULE_IMPORT_NS’
[   25s]    57 | MODULE_IMPORT_NS(DMA_BUF);
[   25s]       | ^~~~~~~~~~~~~~~~

This is simple enough to fix, as seen in torvalds/linux@cdd30eb.

I'll have a PR up shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change MODULE_IMPORT_NS() parameter to string literal for kernels >= 6.13 chrBrd/gasket-driver
1 participant
@chrBrd