Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backport issue in RHEL9.5 #37

Closed
wants to merge 1 commit into from
Closed

Conversation

cyqsimon
Copy link

Similar to #29. It happened yet again for RHEL9.5.

@chrBrd
Copy link
Contributor

chrBrd commented Dec 30, 2024

Patches like this shouldn't be going into upstream IMO.

As mentioned in your first PR there aren't too many instances of conditional compilation. Yet. This PR and the other would add two.

I'm the maintainer for this for openSUSE distros where I have to deal with backports breaking things. If I upstreamed those patches that'd be yet more conditional compilation code. If you multiply this out for every somewhat popular distro then this repo would eventually become a mess.

Patching backport issues is really a distro maintainer's responsibility.

@cyqsimon
Copy link
Author

@chrBrd Yeah it becomes more reasonable the more I think about it. I'll go submit these as source patches for KyleGospo/gasket-dkms I suppose.

@chrBrd
Copy link
Contributor

chrBrd commented Dec 30, 2024

Good call!

Apologies if my comment came off a bit blunt.

@cyqsimon
Copy link
Author

Apologies if my comment came off a bit blunt.

No worries, no offence taken 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants