Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: lost "forcePathStyle" query parameter in AWS SDK V2 #3476

Closed
SebouChu opened this issue Aug 19, 2024 · 2 comments
Closed

aws: lost "forcePathStyle" query parameter in AWS SDK V2 #3476

SebouChu opened this issue Aug 19, 2024 · 2 comments

Comments

@SebouChu
Copy link

Describe the bug

In 0.39.0, S3 URLs now use the V2 of the AWS SDK by default. Therefore, we lost the s3ForcePathStyle query parameter.

Based on their documentation, we might be able to reproduce the behavior of this parameter by allowing to set the HostnameImmutable endpoint option.

To Reproduce

Based on GCK documentation, having an S3URL with s3ForcePathStyle will crash. And removing the parameter might break operations like OpenBucket when endpoint host should not be changed.

Expected behavior

Operations should work with SDK V2, without the removed s3ForcePathStyle, and adding the support of a new parameter to set HostnameImmutable

Version

GCK 0.39.0

@vangent
Copy link
Contributor

vangent commented Aug 19, 2024

See #3472 and #3473.

@SebouChu
Copy link
Author

thanks @vangent! I didn't see the closed issue about this, sorry :(

@vangent vangent closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants