[Data sync status] Improve sync status labels

[gino-m]

@jo-spek @jabramowitz5 We spoke about this but I can't find an FR or notes.

Before	After
Upload pending	Pending
Failed	Pending retry
Syncing	Uploading form data
Data synced\n(media pending)	Photos pending
Data synced\n(media pending retry)	Photos pending retry
Media syncing	Uploading photos
Synced	Uploaded

We should also precede the site name with the marker icon and move it above the user's name data, since it's the primary entity to which the submissions are attached.

Current screen:

@amegantz @rawbzz Wdyt?

We should also update Mutation.SyncStatus to reflect these labels.

[amegantz]

1. "Uploading form data" can just be "Uploading data"
2. Are other media types (e.g. video) supported? If so, I'd keep "media" as is. Otherwise, everything else LGTM

[rawbzz]

I think i remember @gino-m you talking about grouping these also by survey? I took a stab at rearranging some of the type hierarchy

[jo-spek]

@jo-spek @jabramowitz5 We spoke about this but I can't find an FR or notes.

Do you mean the survey name? --> Still pertains to issue #2690. Without a textblock feature, giving text instructions remains tricky.

If you mean creating an FR for changing the terms (Synced --> Uploaded, etc...), I may just quickly change the strings.xml and do a pull request.

[gino-m]

@jo-spek @jabramowitz5 We spoke about this but I can't find an FR or notes.

Do you mean the survey name? --> Still pertains to issue #2690. Without a textblock feature, giving text instructions remains tricky.

If you mean creating an FR for changing the terms (Synced --> Uploaded, etc...), I may just quickly change the strings.xml and do a pull request.

Yes, I was referring to differentiating upload tasks by survey name/title. I think this issue is sufficient to track. Not sure how this is related to #2690.

[jo-spek]

Ah, I only see it now. Was too stuck on the awfully long title in picture 1. Ok!

[gino-m]

1. "Uploading form data" can just be "Uploading data"

@amegantz In that case we might as well just say "Uploading", since I don't think adding "data" will help the user understand it's only the form data that's uploading

2. Are other media types (e.g. video) supported? If so, I'd keep "media" as is. Otherwise, everything else LGTM

Only photos for now.

Updated suggestions:

Before	After
Upload pending	Pending
Failed	Pending retry Retry pending
Syncing	Uploading form data
Data synced\n(media pending)	Photos pending
Data synced\n(media pending retry)	Photos pending retry
Media syncing	Uploading photos

@amegantz Should we use "Complete" or "Done" to indicate an upload is finished?