Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define DrawAreaTaskFragment in XML instead of creating programmatically #2877

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

anandwana001
Copy link
Collaborator

@anandwana001
Copy link
Collaborator Author

This PR is a suggested approach, as the bug is no repro.

@sufyanAbbasi any suggestions?

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.22%. Comparing base (20d1540) to head (7c48958).

Files with missing lines Patch % Lines
...tacollection/tasks/polygon/DrawAreaTaskFragment.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2877      +/-   ##
============================================
+ Coverage     61.20%   61.22%   +0.01%     
  Complexity     1185     1185              
============================================
  Files           267      267              
  Lines          6400     6403       +3     
  Branches        914      914              
============================================
+ Hits           3917     3920       +3     
  Misses         1944     1944              
  Partials        539      539              
Files with missing lines Coverage Δ
...tacollection/tasks/polygon/DrawAreaTaskFragment.kt 61.40% <83.33%> (+2.14%) ⬆️

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need an XML layout for an empty Fragment, especially if the rest of the Fragment is built dynamically?

Also, please include more content in the PR title, eg "Define DrawAreaTaskFragment in XML instead of creating programmatically"

@anandwana001
Copy link
Collaborator Author

Why do we need an XML layout for an empty Fragment, especially if the rest of the Fragment is built dynamically?

As of the error is coming to this particular fragment where we are dynamically generating the view using prime number, so this is one approach where rather than dependent on newly built view, we have our own XML view to use every time which will prevent this error to occur.

@anandwana001 anandwana001 changed the title Replaced dynamic view with xml Define DrawAreaTaskFragment in XML instead of creating programmatically Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRENDING CRASH] IllegalArgumentException: No view found for id 0x42dc8 (unknown) for fragment
4 participants