-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define DrawAreaTaskFragment in XML instead of creating programmatically #2877
base: master
Are you sure you want to change the base?
Conversation
This PR is a suggested approach, as the bug is no repro. @sufyanAbbasi any suggestions? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2877 +/- ##
============================================
+ Coverage 61.20% 61.22% +0.01%
Complexity 1185 1185
============================================
Files 267 267
Lines 6400 6403 +3
Branches 914 914
============================================
+ Hits 3917 3920 +3
Misses 1944 1944
Partials 539 539
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need an XML layout for an empty Fragment, especially if the rest of the Fragment is built dynamically?
Also, please include more content in the PR title, eg "Define DrawAreaTaskFragment in XML instead of creating programmatically"
.../main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskFragment.kt
Outdated
Show resolved
Hide resolved
As of the error is coming to this particular fragment where we are dynamically generating the view using prime number, so this is one approach where rather than dependent on newly built view, we have our own XML view to use every time which will prevent this error to occur. |
Fixes #2749
@shobhitagarwal1612 @gino-m PTAL?