Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code health] Clean up flow of state in SubmissionService #1694

Open
4 tasks
gino-m opened this issue Apr 2, 2024 · 3 comments
Open
4 tasks

[Code health] Clean up flow of state in SubmissionService #1694

gino-m opened this issue Apr 2, 2024 · 3 comments
Assignees
@rfontanarosa
Labels
type: code health Improvements to readability or robustness of codebase
Milestone
GA release

Comments

@gino-m
Copy link
Collaborator

gino-m commented Apr 2, 2024 •
edited by jcqli
Loading

  • Remove select and deselect methods and submissionId state; change submission id via NavigationService instead.
  • Use combineLatestAll to combine at active survey, selected LOI, current user and submissionId$ in NavigationService. Use distinctUntilChanged on the result of combineLatestAll to avoid hitting db multiple times.
  • Emit LOADING when any of the above changes, then loadSubmission$ - use distinctUntilChanged on return value of stream.
  • Remove unused code from MainPageComponent

@rfontanarosa

EDIT: From standup today Oct 23 2024, this above proposal is no longer feasible and needs to be discussed
@gino-m gino-m added the type: code health Improvements to readability or robustness of codebase label Apr 2, 2024
@gino-m gino-m added this to the Beta release (18-Jul-24) milestone Apr 18, 2024
@jcqli jcqli moved this to In Progress in Ground May 20, 2024
@jcqli
Copy link

jcqli commented Jun 17, 2024

Related to Async issues with RxJs

@gino-m
Copy link
Collaborator Author

gino-m commented Jul 30, 2024

Trying to make Beta scope tractable; let's tackle this as part of the push for GA.

@jcqli jcqli moved this from In Progress to Todo in Ground Aug 2, 2024
@jcqli jcqli removed the status in Ground Aug 2, 2024
@rfontanarosa rfontanarosa self-assigned this Sep 9, 2024
@jcqli jcqli moved this to Todo in Ground Sep 11, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Nov 20, 2024

@rfontanarosa Can you meet Daniel to discuss splitting this into smaller tasks?

@kenstershiro kenstershiro moved this from In Progress to Todo in Ground Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rfontanarosa rfontanarosa

Labels
type: code health Improvements to readability or robustness of codebase
Projects
Ground
Status: Todo
Milestone
GA release
Development

No branches or pull requests
3 participants
@gino-m @rfontanarosa @jcqli