Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failures #2494

Open
dbermond opened this issue Feb 25, 2025 · 2 comments
Open

Test Failures #2494

dbermond opened this issue Feb 25, 2025 · 2 comments

Comments

@dbermond
Copy link

The git master branch currently gives me the following test failures:

99% tests passed, 10 tests failed out of 3037

Total Test time (real) = 103.96 sec

The following tests FAILED:
        1897 - HwyMulPairwiseTestGroup/HwyMulPairwiseTest.TestAllSatWidenMulPairwiseAccumulate/AVX3_ZEN4  # GetParam() = 64 (ILLEGAL)
        1898 - HwyMulPairwiseTestGroup/HwyMulPairwiseTest.TestAllSatWidenMulPairwiseAccumulate/AVX3_DL  # GetParam() = 128 (ILLEGAL)
        2425 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllSatWidenMulAccumFixedPoint/AVX3_ZEN4  # GetParam() = 64 (ILLEGAL)
        2426 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllSatWidenMulAccumFixedPoint/AVX3_DL  # GetParam() = 128 (ILLEGAL)
        2449 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllReorderWidenMulAccumulate/AVX3_ZEN4  # GetParam() = 64 (ILLEGAL)
        2450 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllReorderWidenMulAccumulate/AVX3_DL  # GetParam() = 128 (ILLEGAL)
        2457 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllRearrangeToOddPlusEven/AVX3_ZEN4  # GetParam() = 64 (ILLEGAL)
        2458 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllRearrangeToOddPlusEven/AVX3_DL  # GetParam() = 128 (ILLEGAL)
        2465 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllSumOfMulQuadAccumulate/AVX3_ZEN4  # GetParam() = 64 (ILLEGAL)
        2466 - HwyWidenMulTestGroup/HwyWidenMulTest.TestAllSumOfMulQuadAccumulate/AVX3_DL  # GetParam() = 128 (ILLEGAL)
Errors while running CTest

Steps used to build and test:

$ cmake -B build -S highway \
        -G 'Unix Makefiles' \
        -DCMAKE_BUILD_TYPE:STRING='None' \
        -DCMAKE_INSTALL_PREFIX:PATH='/usr' \
        -DBUILD_SHARED_LIBS:BOOL='ON' \
        -DHWY_SYSTEM_GTEST:BOOL='ON' \
        -Wno-dev
$ cmake --build build
$ ctest --test-dir build --output-on-failure

System Information:

  • OS: Arch Linux
  • Highway (sources): git master
  • CMake: 3.31.6
  • Compiler: gcc 14.2.1
  • GTest: 1.15.2
@jan-wassenberg
Copy link
Member

Thanks for letting us know. Sounds like at least two ops are buggy on these targets, which are unfortunately not well-covered in our CI (running natively, rarely with support for these). I'll fire up SDE next week, am out tomorrow.

@jan-wassenberg
Copy link
Member

Looks like these are partially, or mostly, due to a bug in GCC's intrinsics.
_mm512_mask_fpclass_ph_mask calls __builtin_ia32_fpclassph512_mask with an __mmask8which should instead be __mmask32. _mm256_mask_fpclass_ph_mask appears to correctly use mask16.

We can undef this incorrect definition and provide our own.

copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
copybara-service bot pushed a commit that referenced this issue Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants