Skip to content

Commit 08f8c12

Browse files
committed
Updates to KspAATask inputs
* Remove Property<File> usages
1 parent 58d2b1e commit 08f8c12

File tree

2 files changed

+7
-31
lines changed

2 files changed

+7
-31
lines changed

gradle-plugin/lint-baseline.xml

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
errorLine2=" ~~~">
3131
<location
3232
file="src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt"
33-
line="349"
33+
line="347"
3434
column="68"/>
3535
</issue>
3636

@@ -100,28 +100,6 @@
100100
column="67"/>
101101
</issue>
102102

103-
<issue
104-
id="FilePropertyDetector"
105-
message="`Property&lt;File>` is discouraged. Use `RegularFileProperty` or `DirectoryProperty`."
106-
errorLine1=" abstract val jdkHome: Property&lt;File>"
107-
errorLine2=" ~~~~~~~">
108-
<location
109-
file="src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt"
110-
line="407"
111-
column="18"/>
112-
</issue>
113-
114-
<issue
115-
id="FilePropertyDetector"
116-
message="`Property&lt;File>` is discouraged. Use `RegularFileProperty` or `DirectoryProperty`."
117-
errorLine1=" abstract val projectBaseDir: Property&lt;File>"
118-
errorLine2=" ~~~~~~~~~~~~~~">
119-
<location
120-
file="src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt"
121-
line="414"
122-
column="18"/>
123-
</issue>
124-
125103
<issue
126104
id="InternalKgpApiUsage"
127105
message="Avoid using internal Kotlin Gradle Plugin APIs"

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ abstract class KspAATask @Inject constructor(
247247
cfg.languageVersion.set(langVer.split('.', '-').take(2).joinToString("."))
248248
cfg.apiVersion.set(apiVer.split('.', '-').take(2).joinToString("."))
249249

250-
cfg.projectBaseDir.set(File(project.project.projectDir.canonicalPath))
250+
cfg.projectBaseDir.set(project.layout.projectDirectory)
251251
cfg.cachesDir.set(KspGradleSubplugin.getKspCachesDir(project, sourceSetName, target))
252252
cfg.outputBaseDir.set(KspGradleSubplugin.getKspOutputDir(project, sourceSetName, target))
253253
cfg.kotlinOutputDir.set(kotlinOutputDir)
@@ -307,9 +307,7 @@ abstract class KspAATask @Inject constructor(
307307
else -> "${project.name}_$compilationName"
308308
}
309309
if (compilerOptions is KotlinJvmCompilerOptions) {
310-
// TODO: set proper jdk home
311-
cfg.jdkHome.value(File(System.getProperty("java.home")))
312-
310+
cfg.jdkHome.set(File(System.getProperty("java.home")))
313311
val javaVersion = JavaVersion.toVersion(System.getProperty("java.version"))
314312
cfg.jdkVersion.value(javaVersion.majorVersion.toInt())
315313

@@ -404,14 +402,14 @@ abstract class KspGradleConfig @Inject constructor() {
404402
abstract val libraries: ConfigurableFileCollection
405403

406404
@get:Internal
407-
abstract val jdkHome: Property<File>
405+
abstract val jdkHome: DirectoryProperty
408406

409407
@get:Input
410408
@get:Optional
411409
abstract val jdkVersion: Property<Int>
412410

413411
@get:Internal
414-
abstract val projectBaseDir: Property<File>
412+
abstract val projectBaseDir: DirectoryProperty
415413

416414
@get:Internal
417415
abstract val outputBaseDir: DirectoryProperty
@@ -564,7 +562,7 @@ abstract class KspAAWorkerAction : WorkAction<KspAAWorkParameter> {
564562
sourceRoots = gradleCfg.sourceRoots.files.toList()
565563
commonSourceRoots = gradleCfg.commonSourceRoots.files.toList()
566564
libraries = gradleCfg.libraries.files.toList()
567-
projectBaseDir = gradleCfg.projectBaseDir.get()
565+
projectBaseDir = gradleCfg.projectBaseDir.get().asFile
568566
outputBaseDir = gradleCfg.outputBaseDir.get().asFile
569567
cachesDir = gradleCfg.cachesDir.get().asFile
570568
kotlinOutputDir = gradleCfg.kotlinOutputDir.get().asFile
@@ -592,7 +590,7 @@ abstract class KspAAWorkerAction : WorkAction<KspAAWorkParameter> {
592590
KSPJvmConfig.Builder().apply {
593591
this.setupSuper()
594592
javaSourceRoots = gradleCfg.javaSourceRoots.files.toList()
595-
jdkHome = gradleCfg.jdkHome.get()
593+
jdkHome = gradleCfg.jdkHome.get().asFile
596594
javaOutputDir = gradleCfg.javaOutputDir.get().asFile
597595
jvmTarget = gradleCfg.jvmTarget.get()
598596
jvmDefaultMode = gradleCfg.jvmDefaultMode.get()

0 commit comments

Comments
 (0)