Fix lints in KspConfigurations

Author: Goooler

gradle-plugin/lint-baseline.xml

@@ -1,17 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 8.13.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0)" variant="all" version="8.13.0">
 
-    <issue
-        id="EagerGradleConfiguration"
-        message="Use register instead of create"
-        errorLine1="    private val configurationForAll = project.configurations.create(PREFIX).apply {"
-        errorLine2="                                                             ~~~~~~">
-        <location
-            file="src/main/kotlin/com/google/devtools/ksp/gradle/KspConfigurations.kt"
-            line="28"
-            column="62"/>
-    </issue>
-
     <issue
         id="EagerGradleConfiguration"
         message="Use register instead of maybeCreate"
@@ -23,17 +12,6 @@
             column="39"/>
     </issue>
 
-    <issue
-        id="EagerGradleConfiguration"
-        message="Use configureEach instead of whenObjectAdded"
-        errorLine1="                configurationForAll.dependencies.whenObjectAdded {"
-        errorLine2="                                                 ~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/kotlin/com/google/devtools/ksp/gradle/KspConfigurations.kt"
-            line="122"
-            column="50"/>
-    </issue>
-
     <issue
         id="EagerGradleConfiguration"
         message="Use register instead of maybeCreate"

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspConfigurations.kt

@@ -25,10 +25,10 @@ class KspConfigurations(private val project: Project) {
             ?: true
 
     // The "ksp" configuration, applied to every compilation.
-    private val configurationForAll = project.configurations.create(PREFIX).apply {
-        isCanBeConsumed = false
-        isCanBeResolved = false
-        isVisible = false
+    private val configurationForAll = project.configurations.register(PREFIX) {
+        it.isCanBeConsumed = false
+        it.isCanBeResolved = false
+        it.isVisible = false
     }
 
     private fun configurationNameOf(vararg parts: String): String {
@@ -118,17 +118,19 @@ class KspConfigurations(private val project: Project) {
             is KotlinMultiplatformExtension -> {
                 kotlin.targets.configureEach { decorateKotlinTarget(it, isKotlinMultiplatform = true) }
 
-                var reported = false
-                configurationForAll.dependencies.whenObjectAdded {
-                    if (!reported) {
-                        reported = true
-                        val msg = "The 'ksp' configuration is deprecated in Kotlin Multiplatform projects. " +
-                            "Please use target-specific configurations like 'kspJvm' instead."
-
-                        if (allowAllTargetConfiguration) {
-                            project.logger.warn(msg)
-                        } else {
-                            throw InvalidUserCodeException(msg)
+                configurationForAll.configure { configuration ->
+                    var reported = false
+                    configuration.dependencies.configureEach {
+                        if (!reported) {
+                            reported = true
+                            val msg = "The 'ksp' configuration is deprecated in Kotlin Multiplatform projects. " +
+                                "Please use target-specific configurations like 'kspJvm' instead."
+
+                            if (allowAllTargetConfiguration) {
+                                project.logger.warn(msg)
+                            } else {
+                                throw InvalidUserCodeException(msg)
+                            }
                         }
                     }
                 }