Skip to content

Commit

Permalink
Merge pull request #750 from google:fix_mega_validation
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 649248081
  • Loading branch information
maxtext authors committed Jul 4, 2024
2 parents 89edace + eb5cf82 commit b83a7a4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions MaxText/pyconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,9 @@ def validate_and_update_keys(raw_keys, model_keys, config_name: str):
"""Validate and update model specific config keys"""
max_logging.log("Updating following parameters in config\n")

# Currently, Megablox only supports data parallelism
validate_megablox_parallelism(raw_keys)
if raw_keys["num_experts"] > 1:
# Currently, Megablox only supports data parallelism
validate_megablox_parallelism(raw_keys)

for k in model_keys:
max_logging.log(f"{k}: {model_keys[k]}")
Expand Down

0 comments on commit b83a7a4

Please sign in to comment.