Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script to convert llama, mistral, mixtral checkpoints to huggingface format #837

Closed
wants to merge 2 commits into from

Conversation

jwyang-google
Copy link
Collaborator

@jwyang-google jwyang-google commented Aug 20, 2024

No description provided.

@jwyang-google jwyang-google changed the title script to convert llama, mistral, mixtral checkpoints to huggingface script to convert llama, mistral, mixtral checkpoints to huggingface format Aug 20, 2024
MaxText/llama_mistral_mixtral_orbax_to_hf.py Outdated Show resolved Hide resolved
MaxText/llama_mistral_mixtral_orbax_to_hf.py Show resolved Hide resolved
Copy link
Collaborator

@gobbleturk gobbleturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, can we also have @khatwanimohit review?

We should add nightly e2e tests for this as well, especially since we have been prone to change our maxtext checkpoint format so this may become out of date without tests

@jwyang-google
Copy link
Collaborator Author

We should add nightly e2e tests for this as well, especially since we have been prone to change our maxtext checkpoint format so this may become out of date without tests

Makes sense. I will take a look at how to add the test soon

@jwyang-google jwyang-google force-pushed the llama_mistral_mixtral_hf_conversion branch from 3b259e5 to 719ae2f Compare September 13, 2024 17:10
@jwyang-google
Copy link
Collaborator Author

I messed up the commits. I will close this and open a new PR on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants