Fix lint errors. #899
Closed
Fix lint errors. #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shralex
force-pushed
the
shralex_fix_lint_errors
branch
2 times, most recently
from
09af7d9
to
397ef74
Compare
gobbleturk
approved these changes
Sep 19, 2024
gobbleturk
reviewed
Sep 19, 2024
| "\n", | ||
| "\n", | ||
| "ckpt_path = '/local/path/gemma-2b-flax/2b/'\n", |
There was a problem hiding this comment.
This one is a bit surprising, our pylint prefers escaping double quote to single quote, but still looks fine
shralex
force-pushed
the
shralex_fix_lint_errors
branch
2 times, most recently
from
a961dec
to
7501038
Compare
PiperOrigin-RevId: 676114023
shralex
force-pushed
the
shralex_fix_lint_errors
branch
from
7501038
to
7944524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pyink and pylint errors so that code_style.sh passes.