Adds a new end-to-end test for Mistral 7b #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shralex
force-pushed
the
shralex_mistral_test
branch
from
88e09e3
to
f00d1e2
Compare
khatwanimohit
approved these changes
Sep 20, 2024
| @@ -0,0 +1,42 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # This file runs on daily basis and demonstrates: | |||
There was a problem hiding this comment.
nit: mention where we run this test. v4-8 in this case.
gobbleturk
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
I guess this file should be split into 2 parts like the rest, but that is unrelated to fix here so okay to leave for now
There was a problem hiding this comment.
It was previously split, and merged into one by Mohit's request, since this is a small model.
There was a problem hiding this comment.
ah makes sense, sounds good!
shralex
force-pushed
the
shralex_mistral_test
branch
from
f00d1e2
to
72a8988
Compare
- A notebook in scratch_pad that runs the model from HF, for sample inputs and generates logits, which it stores in a file. - A test that downloads the HF checkpoint, converts it to MaxText-compatible format, and uses it to do one forward pass on a sample input. - Compares the logits obtained in both steps above to make sure they're equal. The old test, which asserted on the generated text being equal, rather than logits, is removed.
shralex
force-pushed
the
shralex_mistral_test
branch
from
72a8988
to
6037123
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include:
The old test, which asserted on the generated text being equal, rather than logits, is removed.