The symbol file name embedded in mozc_tip32.dll built with Bazel is mozc_tip.pdb rather than mozc_tip32.dll.pdb
#1108
Assignees
Comments
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Nov 1, 2024
This reworks my previous commits [1][2][3], which aimed to make it configurable on which executable should be built with what build configurations (e.g. CRT link type, target CPU architecture). One thing we need to further consider is the debug symbol name embedded in each artifact executable [4]. To generate debug symbols one can use 'generate_pdb_file' feature. The issue is that the pdb filename is not configurable in 'rules_cc'. For instance, if the target name is 'mozc_tip32', then 'rules_cc' assumes that the output pdb file is always 'mozc_tip32.pdb'. To make it 'mozc_tip32.dll.pdb', the target name must be 'mozc_tip32.dll.dll'. This is why I had do rework Win32 build transition rules. Implementation note: * The reason why 'mozc_win32_cc_prod_binary' needs to be introduced is because the final executable name needs to be available as an input of 'mozc_cc_binary'. * 'mozc_cc_win32_library' also needs to be reworked so that 'generate_pdb_file' feature will not be applied to it. There must be no observable change in GYP build and non-Windows bazel builds. Closes google#1108. [1]: 5efa371 [2]: ff64988 [3]: ea55af0 [4]: 0377ddd
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Nov 1, 2024
This reworks my previous commits [1][2][3], which aimed to make it configurable on which executable should be built with what build configurations (e.g. CRT link type, target CPU architecture). One thing we need to further consider is the debug symbol name embedded in each artifact executable [4]. To generate debug symbols one can use 'generate_pdb_file' feature. The issue is that the pdb filename is not configurable in 'rules_cc'. For instance, if the target name is 'mozc_tip32', then 'rules_cc' assumes that the output pdb file is always 'mozc_tip32.pdb'. To make it 'mozc_tip32.dll.pdb', the target name must be 'mozc_tip32.dll.dll'. This is why I had do rework Win32 build transition rules. Implementation note: * The reason why 'mozc_win32_cc_prod_binary' needs to be introduced is because the final executable name needs to be available as an input of 'mozc_cc_binary'. * 'mozc_cc_win32_library' also needs to be reworked so that 'generate_pdb_file' feature will not be applied to it. There must be no observable change in GYP build and non-Windows bazel builds. Closes google#1108. [1]: 5efa371 [2]: ff64988 [3]: ea55af0 [4]: 0377ddd
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Nov 19, 2024
This reworks my previous commits [1][2][3], which aimed to make it configurable on which executable should be built with what build configurations (e.g. CRT link type, target CPU architecture). One thing we need to further consider is the debug symbol name embedded in each artifact executable [4]. To generate debug symbols one can use 'generate_pdb_file' feature. The issue is that the pdb filename is not configurable in 'rules_cc'. For instance, if the target name is 'mozc_tip32', then 'rules_cc' assumes that the output pdb file is always 'mozc_tip32.pdb'. To make it 'mozc_tip32.dll.pdb', the target name must be 'mozc_tip32.dll.dll'. This is why I had do rework Win32 build transition rules. Implementation note: * The reason why 'mozc_win32_cc_prod_binary' needs to be introduced is because the final executable name needs to be available as an input of 'mozc_cc_binary'. * 'mozc_cc_win32_library' also needs to be reworked so that 'generate_pdb_file' feature will not be applied to it. There must be no observable change in GYP build and non-Windows bazel builds. Closes google#1108. [1]: 5efa371 [2]: ff64988 [3]: ea55af0 [4]: 0377ddd
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Nov 23, 2024
This reworks my previous commits [1][2][3], which aimed to make it configurable on which executable should be built with what build configurations (e.g. CRT link type, target CPU architecture). One thing we need to further consider is the debug symbol name embedded in each artifact executable [4]. To generate debug symbols one can use 'generate_pdb_file' feature. The issue is that the pdb filename is not configurable in 'rules_cc'. For instance, if the target name is 'mozc_tip32', then 'rules_cc' assumes that the output pdb file is always 'mozc_tip32.pdb'. To make it 'mozc_tip32.dll.pdb', the target name must be 'mozc_tip32.dll.dll'. This is why I had do rework Win32 build transition rules. Implementation note: * The reason why 'mozc_win32_cc_prod_binary' needs to be introduced is because the final executable name needs to be available as an input of 'mozc_cc_binary'. * 'mozc_cc_win32_library' also needs to be reworked so that 'generate_pdb_file' feature will not be applied to it. There must be no observable change in GYP build and non-Windows bazel builds. Closes google#1108. [1]: 5efa371 [2]: ff64988 [3]: ea55af0 [4]: 0377ddd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This follows up to the following task, where we started deploying
mozc_tip32.dll.pdbto users' environments.mozc_tip64.dll.pdb#1082As noted in the commit 0377ddd, the symbol file name embedded in
mozc_tip32.dllbuilt with Bazel ismozc_tip.pdbrather thanmozc_tip32.dll.pdb. Let's fix this so that we can fully switch to Bazel build to deprecate GYP build.Steps to reproduce
bazel --bazelrc=windows.bazelrc build --config oss_windows --config release_build //win32/installer:mozc_tip32cp bazel-bin\win32\installer\mozc_tip32.dll .dumpbin /headers mozc_tip32.dll | findstr cvExpected behavior
You would see
mozc_tip32.dll.pdbin the output.Actual behavior
You see
mozc_tip.pdbin the output.Version or commit-id
ad3bee0
Environment
The text was updated successfully, but these errors were encountered: