Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop WORKSPACE support from Bazel builds #1115

Closed
yukawa opened this issue Nov 2, 2024 · 0 comments · Fixed by #1116
Closed

Drop WORKSPACE support from Bazel builds #1115

yukawa opened this issue Nov 2, 2024 · 0 comments · Fixed by #1116
Assignees
@yukawa

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 2, 2024

Description

As discussed in the following issue, Mozc has successfully migrated to bzlmod.

Given that no one is the Mozc team is actively testing and maintaining non-bzlmod build configuration, it would make much sense to make it clear that only bzlmod is now supported to build Mozc with Bazel by removing WORKSPACE support completely.

Version or commit-id

e1b40ed
@yukawa yukawa pinned this issue Nov 2, 2024
yukawa added a commit to yukawa/mozc that referenced this issue Nov 2, 2024
@yukawa
Remove WORKSPACE support from Bazel builds
a0265bd 
As Mozc has already migrated to bzlmod from WORKSPACE, let's remove
obsolete and unmaintained WORKSPACE-related files and configs to make it
clear that WORKSPACE is no longer supported to build Mozc with Bazel.

Closes google#1115.
@yukawa yukawa mentioned this issue Nov 2, 2024
Merged
@yukawa yukawa self-assigned this Nov 2, 2024
yukawa added a commit to yukawa/mozc that referenced this issue Nov 5, 2024
@yukawa
Remove obsolete build options from .bazelrc
674ed28 
This commit removes the following bazel options that were originally
added [1] to support bzlmod for Android (google#1002).

 - experimental_enable_android_migration_apis
 - experimental_google_legacy_api

As far as we can see with Bazel 7.4.0, building Mozc with Bazel just
succeeds without the above two options in all the supported platforms.

This is a preparation to fully deprecate WORKSPACE support (google#1115).

Closes google#1117.

 [1]: 699c2ce
@yukawa yukawa mentioned this issue Nov 5, 2024
Merged
@yukawa yukawa unpinned this issue Jan 8, 2025
hiroyuki-komatsu added a commit that referenced this issue Jan 16, 2025
@hiroyuki-komatsu
Update BUILD_OSS to 5712
58ebfad 
2.30.5618 → 2.31.5712

Conversion
* Updated the LM dictionary
* Updated symbols (#1074, #1100)
* Updated emoji data to CLDR 46 (Emoji 16.0)
* Fixed conversion errors reported by users.

Bug fix
* Windows: fixed the freeze issue with some applications like the searchhost.exe (#1077, #856)
* Windows: fixed the UI language issue of the GUI tools (#1110)

Features
* Updated the copyright year to 2025.
* Windows: bundle debug symbol for Mozc TIP DLL (#1081)
* Windows: shutdown existing Mozc processes on upgrading the version (#1093)

Build
* supported Bazel 8.0.0 (#1118)
* removed WORKSPACE support for Bazel (#1115)
* supported Python 3.14 (#1084)
* updated the protobuf version: v27.3 → v29.1.
* Linux: supported gcc-14.1.1 without additional build flags (#927)
* macOS / Windows: Updated Qt version: 6.7.3 → 6.8.0 (#1105, #1110, #1121)

Code
* added a lint checker for BUILD.bazel and *bzl files (#1089)
* renamed the protobuf field from Candidates to CandidateWindow
* refactoring of ConversionRequest making it as immutable object
* refactoring of the Converter implementation
* refactoring of Engine and SessionConverter to make each module pluggable
* removed cyclic dependency between Converter and Rewriter.

PiperOrigin-RevId: 716215275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yukawa yukawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove WORKSPACE support from Bazel builds yukawa/mozc
1 participant
@yukawa