Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

imagereplace attack doesn't replace some images #92

Open
klyubin opened this issue Sep 23, 2015 · 1 comment
Open

imagereplace attack doesn't replace some images #92

klyubin opened this issue Sep 23, 2015 · 1 comment

Comments

@klyubin
Copy link
Contributor

klyubin commented Sep 23, 2015

The imagereplace attack doesn't always replace images. I wonder if it's because it can't handle some image types (e.g., webp).

@klyubin klyubin changed the title imagereplace attach doesn't replace some images imagereplace attack doesn't replace some images Sep 23, 2015
@chadbrubaker
Copy link
Contributor

It should support anything with a content type that starts with image, see https://github.com/google/nogotofail/blob/dev/nogotofail/mitm/connection/handlers/data/http.py#L416

It could be more issues with the http detection?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants