-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Installer log file preservation #201
Comments
The log file is still accessible before Omaha cleans up the directory. I believe the intention was to collect a log file, and retrieve it for analysis before Omaha exited and eventually uninstalled itself. |
Hmmm, I guess you'd need to be quick to get the log file between it being closed and cleaned up. After a bit more investigation, it transpires there are numerous ways to instruct Windows Installer how to log: https://docs.microsoft.com/en-us/windows/win32/msi/normal-logging The current explicit Furthermore, the I'm removing the switch entirely from my repo so as to fall back on the other mechanisms. Thanks. |
What scenario are you trying to debug using the msi log? Generally speaking, Omaha will clean up its install directory when it instantiates an InstallManager object: https://github.com/google/omaha/blob/master/omaha/goopdate/install_manager.cc#L75 Re: the MSI |
I'm running some automated functional tests as part of a build and release pipeline. They simulate the full lifecycle of the app: install, run some tests, then uninstall. At the moment I'm getting occasional install issues and need the msi log file to diagnose what went on. Yes, sorry, I missed those later command-line options so scrub what I said about the /log switch. I would still suggest it is not ideal that Omaha overrides any environmental settings for msi logging and then ensures the log file it specifies is deleted. Cheers. |
Understood. Would something such as a registry option to disable the MSI logging work for you? |
Yes, that would be great. |
|
View my script on TradingView |
Fix support |
[email protected] |
From what I can tell, Omaha enables
msiexec
log file output - for example to the following temporary path:"C:\Program Files (x86)\Google\GoogleUpdate\Install\{B5F9BEF5-1D04-4FF5-AD92-4D1E21D76F51}\xyz.msi.log"
However, the containing folder is then deleted along with the log file during cleanup, AFAIK.
Is there a switch I'm missing to have this log file preserved. That's what I would like in order to diagnose problematic installs.
If not, what is the point in generating the msi log file which does tend to slow thing down?
Thanks a lot.
The text was updated successfully, but these errors were encountered: