Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick detection seems to occassionally add unrelated commits #1248

Open
oliverchang opened this issue Apr 26, 2023 · 2 comments
Open
Labels
backlog Important but currently unprioritized bug Something isn't working infra infrastructure bugs/FRs

Comments

@oliverchang
Copy link
Collaborator

Context: google/oss-fuzz-vulns#34 (comment)

The offending commit (e8a86ab6c84f6618fae6f961c34c25ef42e91332) does not actually exist in the qtsvg repo.

@oliverchang oliverchang added bug Something isn't working infra infrastructure bugs/FRs labels Apr 26, 2023
@rlohning
Copy link

The mentioned commit is from a parent repository. That repository contains a submodule (qtsvg) which received the actual fix. Still, having e8a86ab in the database isn't helpful because the submodules are checked out to later revisions than were committed to the parent repo.
If e8a86ab was the first revision of the parent that was tested after the submodule got the fix, then that's just a coincidence.

Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 24, 2024
@andrewpollock andrewpollock added the backlog Important but currently unprioritized label Jul 26, 2024
@oliverchang oliverchang removed the stale The issue or PR is stale and pending automated closure label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Important but currently unprioritized bug Something isn't working infra infrastructure bugs/FRs
Projects
None yet
Development

No branches or pull requests

3 participants