Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and enable cherrypick detection for cve-osv #2577

Open
oliverchang opened this issue Sep 9, 2024 · 2 comments
Open

Evaluate and enable cherrypick detection for cve-osv #2577

oliverchang opened this issue Sep 9, 2024 · 2 comments
Labels
data quality Issues with data quality enhancement New feature or request stale The issue or PR is stale and pending automated closure

Comments

@oliverchang
Copy link
Collaborator

oliverchang commented Sep 9, 2024

Currently, for our cve-osv source, detect_cherrypicks is off. This means that when we enumerate affected git commits, we are only considering the branches that contain the referenced fix commits.

This occasionally lead to missed matches.

We should evaluate turning on cherrypick detection for cve-osv. This has some implications:

  • This will slow down record processing time.
  • Cherrypick detection is not perfect, which can lead to false positives if we don't correctly identify all cherrypicked fixes.

Related issues:
#2576 (comment)
#1910 (comment)

@oliverchang oliverchang added enhancement New feature or request data quality Issues with data quality labels Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

✨ Thank you for your interest in OSV.dev's data quality! ✨

Please review our FAQ entry on how to most efficiently have this addressed.

Copy link

github-actions bot commented Nov 8, 2024

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data quality Issues with data quality enhancement New feature or request stale The issue or PR is stale and pending automated closure
Projects
None yet
Development

No branches or pull requests

1 participant