Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better validation for API requests. #892

Open
oliverchang opened this issue Dec 8, 2022 · 3 comments
Open

Better validation for API requests. #892

oliverchang opened this issue Dec 8, 2022 · 3 comments
Labels
api API-related infrastructure backlog Important but currently unprioritized infra infrastructure bugs/FRs

Comments

@oliverchang
Copy link
Collaborator

We can validate:

  1. The provided version is valid for the given ecosystem. We can simply do this by attempting to parse the provided version, if an ecosystem is specified.
  2. The provided package and version number exists in the ecosystem (this will need https://deps.dev support).
@oliverchang oliverchang added api API-related infrastructure infra infrastructure bugs/FRs labels Dec 8, 2022
@andrewpollock
Copy link
Contributor

Based on my read of b/291986718, also when an invalid/unsupported ecosystem is provided

andrewpollock added a commit to andrewpollock/osv.dev that referenced this issue Jul 21, 2023
@andrewpollock
Validate the ecosystem used in queries
c9b6bf5 
Partially addresses google#892
@andrewpollock andrewpollock mentioned this issue Jul 21, 2023
Merged
andrewpollock added a commit that referenced this issue Jul 24, 2023
@andrewpollock
Validate the ecosystem used in queries (#1485)
4263556 
Partially addresses #892
@github-actions GitHub Actions
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 27, 2024
@github-actions GitHub Actions
Copy link

Automatically closing stale issue

@github-actions github-actions bot added the autoclosed Closed by automation label Aug 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2024
@oliverchang oliverchang added backlog Important but currently unprioritized and removed stale The issue or PR is stale and pending automated closure labels Aug 11, 2024
@oliverchang oliverchang reopened this Aug 11, 2024
@github-actions github-actions bot removed the autoclosed Closed by automation label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API-related infrastructure backlog Important but currently unprioritized infra infrastructure bugs/FRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverchang @andrewpollock