{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":33134439,"defaultBranch":"master","name":"packetdrill","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-03-30T16:24:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1427732811.0","currentOid":""},"activityList":{"items":[{"before":"0312055f6dde4742d11f1e775ac7fe5fcefe49b8","after":"8051382e6ac928c4c13a88b34832649d9b07abc2","ref":"refs/heads/master","pushedAt":"2024-07-26T14:35:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: new behaviour change for simult TFO connect\n\nA fix for the kernel commit 23e89e8ee7be (\"tcp: Don't drop SYN+ACK for\nsimultaneous connect().\") has recently been shared on Netdev [1].\n\nThe ACK is back -- recently removed by commit 0312055 (\"net-test:\nbehaviour change for simultaneous TFO connect\") -- but this time with\nthe DSACK, as expected, see [1] and [2].\n\nLink: https://lore.kernel.org/r/20240724-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v3-1-d48339764ce9@kernel.org [1]\nLink: https://lore.kernel.org/r/CADVnQy=Aky08HJGnozv-Nd97kRHBnxhw+caks+42FUyn+9GbPQ@mail.gmail.com [2]\nSigned-off-by: Matthieu Baerts (NGI0) ","shortMessageHtmlLink":"net-test: new behaviour change for simult TFO connect"}},{"before":"31fbbb79d2d5cec1524ad80a2fc8359971104d1d","after":"0312055f6dde4742d11f1e775ac7fe5fcefe49b8","ref":"refs/heads/master","pushedAt":"2024-07-17T18:08:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: behaviour change for simultaneous TFO connect\n\nSince the kernel commit 23e89e8ee7be (\"tcp: Don't drop SYN+ACK for\nsimultaneous connect().\"), the behaviour has changed for the\nsimultaneous connect case: an unnecessary ACK is no longer sent.\n\nWe can then remove it from this packetdrill test checking this specific\nbehaviour.\n\nLink: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=23e89e8ee7be\nSigned-off-by: Matthieu Baerts (NGI0) ","shortMessageHtmlLink":"net-test: behaviour change for simultaneous TFO connect"}},{"before":"8595c94c9cbb46cb4828ab3db0c71ad5c9b854af","after":"31fbbb79d2d5cec1524ad80a2fc8359971104d1d","ref":"refs/heads/master","pushedAt":"2023-09-29T01:53:15.000Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: run_all: add --dry_run mode\n\nIt is useful to have an easy way to display the commands that are going\nto be executed: for debugging purposes, to relaunch one specific test\nwith different arguments or from a different environment, etc.\n\nNow a new '--dry_run' parameter is available to only display commands\nand not execute anything.\n\nSigned-off-by: Matthieu Baerts ","shortMessageHtmlLink":"net-test: packetdrill: run_all: add --dry_run mode"}},{"before":"7c730a01c45279fffdc9d599252e7299bed9dd7d","after":"8595c94c9cbb46cb4828ab3db0c71ad5c9b854af","ref":"refs/heads/master","pushedAt":"2023-08-10T20:37:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: ensure --wire_client and --wire_server cancel opposing flags\n\nAttempt to fix a bug reported on the packetdrill mailing list:\n\n https://groups.google.com/g/packetdrill/c/SIZSjTe8uTM/m/u56xAVQTAAAJ\n\nThe debug output in packetdrill_server.debug.output showed that the\nwire_server was parsing the --wire_server_at=10.4.99.103 argument,\npresumably causing the wire_server to set config->is_wire_client =\ntrue while parsing that argument, thus making the wire_server believe\nit was a wire_client, and thus causing it to die with the error\nmessage:\n\n please specify --wire_client_dev=\n\nThe proposed fix here is to ensure that when the wire server attempts\nto override the is_wire_client = true effect of the --wire_server_at=\noption using the --wire_server flag, this step actually indeed\noverrides the is_wire_client = true setting by setting is_wire_client\n= false.\n\nSigned-off-by: Neal Cardwell ","shortMessageHtmlLink":"net-test: packetdrill: ensure --wire_client and --wire_server cancel …"}},{"before":"40894edb1d3ce279ecda8914aaab66aa7000a634","after":"7c730a01c45279fffdc9d599252e7299bed9dd7d","ref":"refs/heads/master","pushedAt":"2023-08-10T20:28:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"Revert \"net-test: packetdrill: bug fix: wire_server must ignore new --wire_server_at arg\"\n\nThis reverts commit 40894edb1d3ce279ecda8914aaab66aa7000a634.","shortMessageHtmlLink":"Revert \"net-test: packetdrill: bug fix: wire_server must ignore new -…"}},{"before":"c2b94c5eba9bd8660d50dcc8202eac9ea10fa42e","after":"40894edb1d3ce279ecda8914aaab66aa7000a634","ref":"refs/heads/master","pushedAt":"2023-08-02T16:13:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: bug fix: wire_server must ignore new --wire_server_at arg\n\nFix a bug reported on the packetdrill mailing list:\n https://groups.google.com/g/packetdrill/c/SIZSjTe8uTM/m/u56xAVQTAAAJ\n\nThe debug output in packetdrill_server.debug.output showed that the\nwire_server was parsing the --wire_server_at=10.4.99.103 argument,\npresumably causing the wire_server to set config->is_wire_client =\ntrue while parsing that argument, thus making the wire_server believe\nit was a wire_client, and thus causing it to die with the error\nmessage:\n\n please specify --wire_client_dev=\n\nThe fix is to ensure that packetdrill treats the new --wire_server_at\nargument like the existing --wire_client argument, where we ensure\nthat the wire server does not use this argument.\n\nWhile we're at it, tighten up the code to ignore client-only args, and\nenforce this on the server side in wire_server_unserialize_argv(), in\ncase the client-sdie wire_client_serialize_argv() is buggy (as it was\nhere).\n\nSigned-off-by: Neal Cardwell ","shortMessageHtmlLink":"net-test: packetdrill: bug fix: wire_server must ignore new --wire_se…"}},{"before":"e5b6611f00927757fd8f6903246a7cbc9c0af1a2","after":"c2b94c5eba9bd8660d50dcc8202eac9ea10fa42e","ref":"refs/heads/master","pushedAt":"2023-05-21T18:56:23.706Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: add README.md details about IP addresses for test traffic\n\nSigned-off-by: Neal Cardwell \nChange-Id: I5a6851f6de7e7f71e9f838c8f9e1700aafe64392","shortMessageHtmlLink":"net-test: packetdrill: add README.md details about IP addresses for t…"}},{"before":"1bca284fba731d7b74382612047909795e8dbc05","after":"e5b6611f00927757fd8f6903246a7cbc9c0af1a2","ref":"refs/heads/master","pushedAt":"2023-05-20T18:39:41.422Z","pushType":"push","commitsCount":20,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: update README.md to add docs for local and remote mode\n\nNow that the details of remote mode have changed, add documentation to\ndescribe the latest details of local and remote mode.\n\nSigned-off-by: Neal Cardwell \nChange-Id: Ibb57d7d70ac093c2008369b19b94b311b6a99ff2","shortMessageHtmlLink":"net-test: packetdrill: update README.md to add docs for local and rem…"}},{"before":"8229c94928ac0c7d5039bc3d302c525d558934f7","after":"1bca284fba731d7b74382612047909795e8dbc05","ref":"refs/heads/master","pushedAt":"2023-05-10T19:56:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: fail test when packet doesn't arrive\n\nIn the case where a packetdrill test expects a packet it makes a\nblocking recvfrom call, causing test failures due to missing packets\nto hang indefinitely until the test infrastructure invoking the\npacketdrill process times out. If packetdrill is being run\ninteractively, the user must hit ctrl-C or similar to manually\nterminate the test.\n\nThis commit uses the SO_RECVTIMEO socket option to timeout the test\nafter the packet's expected arrival + a 2 second buffer.\n\nIf the kernel under test does not send packet within the 2-second\nperiod, packetdrill causes the test to fail and prints an error\nmessage like:\n error handling packet: Timed out waiting for packet\n\nSigned-off-by: David Morley \nChange-Id: I6999236d9fee78b73bd29ba8e82a963c8a51e2db","shortMessageHtmlLink":"net-test: packetdrill: fail test when packet doesn't arrive"}},{"before":"bfc96251310f80b92b57b33a30d4251317e3b9ba","after":"8229c94928ac0c7d5039bc3d302c525d558934f7","ref":"refs/heads/master","pushedAt":"2023-05-06T17:50:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: add TCP slow start, fast retransmit, and PRR tests\n\nRelated RFCs:\nRFC 5681: TCP Congestion Control\nRFC 6937: Proportional Rate Reduction for TCP\n\nNote: Since Linux 3.13, slow start no longer follows RFC 3742 (Limited\nSlow-Start) or RFC 3465 (Appropriate Byte Counting). 9f9843a751d0a\n\nMany thanks to the following Googlers for their contributions over\nthe years to theses tests, which are reflected in this patch:\n\nNeal Cardwell\nPriyaranjan Jha\nYuchung Cheng\nEric Dumazet\nTanner Love\nWei Wang\nShuo Chen\nMaciej Żenczykowski\nNandita Dukkipati\nChonggang Li\n\nTested on Linux 6.1 running on GCE.\n\nSigned-off-by: Shuo Chen \nSigned-off-by: Willem de Bruijn \nSigned-off-by: Neal Cardwell ","shortMessageHtmlLink":"net-test: packetdrill: add TCP slow start, fast retransmit, and PRR t…"}},{"before":"32eaf40c2028d35cb2d489b01a2cf081954a74f6","after":"bfc96251310f80b92b57b33a30d4251317e3b9ba","ref":"refs/heads/master","pushedAt":"2023-05-03T22:13:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: add TCP fastopen testcases\n\nAdd tests for TCP Fast Open (RFC 7413).\n\nThese tests have many authors (thanks!). We only upstream them here.\n\nTested on Linux 6.1 running on GCE.\n\n---\n\nMaintainer's note:\n\nMany thanks to heroic work by Shuo Chen to get these tests upstream!\n\nAlso, many thanks to the following Googlers for their contributions\nover the years to theses tests, which are reflected in this patch:\n\nYuchung Cheng\nWei Wang\nNeal Cardwell\nEric Dumazet\nMaciej Żenczykowski\nJerry Chu\nLuke Hsiao\nTanner Love\nShuo Chen\nPriyaranjan Jha\nJohn Sperbeck\nChonggang Li\n\nSigned-off-by: Shuo Chen \nSigned-off-by: Willem de Bruijn \nSigned-off-by: Neal Cardwell ","shortMessageHtmlLink":"net-test: packetdrill: add TCP fastopen testcases"}},{"before":"e44f47687541c509f1405b160d800b9e7730804c","after":"32eaf40c2028d35cb2d489b01a2cf081954a74f6","ref":"refs/heads/master","pushedAt":"2023-04-28T14:38:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: update README.md to recommend installing net-tools\n\nUpdate READDDME.md to recommend installing the net-tools package.\nOtherwise on recent Ubuntu distributions many tests fail with errors\nincluding:\n\n sh: 1: ifconfig: not found\n\nSigned-off-by: Neal Cardwell ","shortMessageHtmlLink":"net-test: packetdrill: update README.md to recommend installing net-t…"}},{"before":"79e02ce694d90a808574a8a6076978f73b5a2c61","after":"e44f47687541c509f1405b160d800b9e7730804c","ref":"refs/heads/master","pushedAt":"2023-04-28T14:37:13.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"nealcardwell","name":"Neal Cardwell","path":"/nealcardwell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11696413?s=80&v=4"},"commit":{"message":"net-test: packetdrill: switch to Python3\n\nOriginal-by: John Sperbeck\nSigned-off-by: Shuo Chen \nChange-Id: Ic99277dfb9ed9fd26f3966dcf30de8e6c0a4ed0e","shortMessageHtmlLink":"net-test: packetdrill: switch to Python3"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0yNlQxNDozNTo1Ny4wMDAwMDBazwAAAASKIRZr","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNC0yOFQxNDozNzoxMy4wMDAwMDBazwAAAAMiXOF3"}},"title":"Activity · google/packetdrill"}