From 2ddbda7b1e5d446bb3740d1ecba64de85c231cf8 Mon Sep 17 00:00:00 2001 From: Lalit Maganti Date: Thu, 23 Jan 2025 16:07:51 +0000 Subject: [PATCH] ui: fix accidental split on colon in flamegraph filter string split did not work the way I thought it did. Fixes: 391859336 Change-Id: Ie629f91e3788489c9357d04e99093c10f276e89b --- ui/src/widgets/flamegraph.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/widgets/flamegraph.ts b/ui/src/widgets/flamegraph.ts index 7a3b022298..985c3301e3 100644 --- a/ui/src/widgets/flamegraph.ts +++ b/ui/src/widgets/flamegraph.ts @@ -927,7 +927,7 @@ function displayPercentage(size: number, totalSize: number): string { function updateState(state: FlamegraphState, filter: string): FlamegraphState { const lwr = filter.toLowerCase(); - const splitFilterFn = (f: string) => f.split(':', 2)[1].trim(); + const splitFilterFn = (f: string) => f.substring(f.indexOf(':') + 1).trim(); if (lwr.startsWith('ss:') || lwr.startsWith('show stack:')) { return addFilter(state, { kind: 'SHOW_STACK',