Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systrace conversion loses information about ftrace flags #950

Open
ChunelFeng opened this issue Nov 27, 2024 · 3 comments
Open

Systrace conversion loses information about ftrace flags #950

ChunelFeng opened this issue Nov 27, 2024 · 3 comments
Labels
bug Something isn't working fixit good first issue Good for newcomers

Comments

@ChunelFeng
Copy link

as you know, i use v30.0 as default,

Image

when we try to translate perfetto dump file to xxx.strace,
it shows lost some of state.

this state need enable some cfg by my_test.cfg,
or just has no such info?

Image

@LalitMaganti LalitMaganti changed the title i use webui, translate perfetto dump file to strace, but loss some state Systrace conversion loses information about ftrace flags Nov 27, 2024
@LalitMaganti
Copy link
Collaborator

LalitMaganti commented Nov 27, 2024

When converting to systrace, we try and preserve as much information as we can but the conversion is a lossy process. One of the things which is not preserved is the systrace flags, we just hardcode .....

It might be possible to fix this by reading the flags from the ftrace table and determining what the textural flags are and write it out in the conversion code [1] but I'm not sure if we actually have the information to do this present in the trace at all.

In any case, this is one of those niche cases where contributions are welcome to fix this issue (it's actually a pretty self-contained issue) but given this is the first time this question is asked in 7 years of Perfetto, not a priority for us to fix.

[1] https://cs.android.com/android/platform/superproject/main/+/main:external/perfetto/src/trace_processor/perfetto_sql/intrinsics/functions/to_ftrace.cc;l=700?q=%22writer-%3EAppendLiteral(%5C%22%5D%20....%20%5C%22);%22

@LalitMaganti LalitMaganti added bug Something isn't working good first issue Good for newcomers fixit labels Nov 27, 2024
@ChunelFeng
Copy link
Author

hi, any news about this issue?

@LalitMaganti
Copy link
Collaborator

What news are you expecting? As I said, this is not a priority for us to fix. Patches welcome but we're not doing anything on this for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixit good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants