From baa2ccfa948e1048de751456b5574ba114be31b6 Mon Sep 17 00:00:00 2001 From: Sax Authors Date: Wed, 11 Sep 2024 11:23:47 -0700 Subject: [PATCH] sax admin: don't close the channel on kUnavailable errors. PiperOrigin-RevId: 673467645 Change-Id: I10d861ca4582f26912f18754941856cc27624804 --- saxml/client/go/admin.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/saxml/client/go/admin.go b/saxml/client/go/admin.go index 718ace16..96e68660 100644 --- a/saxml/client/go/admin.go +++ b/saxml/client/go/admin.go @@ -120,27 +120,12 @@ func (a *Admin) getAdminClient(ctx context.Context) (pbgrpc.AdminClient, error) return a.client, nil } -func (a *Admin) poison() { - a.mu.Lock() - conn := a.conn - a.conn = nil - a.client = nil - a.mu.Unlock() - - if conn != nil { - conn.Close() - } -} - func (a *Admin) retry(ctx context.Context, callback func(client pbgrpc.AdminClient) error) error { action := func() error { client, err := a.getAdminClient(ctx) if err == nil { err = callback(client) } - if errors.AdminShouldPoison(err) { - a.poison() - } return err } return retrier.Do(ctx, action, errors.AdminShouldRetry)