-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Extend exemplary usage #112
Comments
Thanks for the suggestion! Documenting Helmet usage is a good idea. If you would like to contribute something here, I'm happy to review it! I can whip something up otherwise |
Originally suggested in google/schema-dts#112 Wraps returned innerHTML with safeJsonLdReplacer as well, since Helmet will similarly just pass innerHTML as-is to dangerouslySetInnerHTML.
I'll add some docs here, but I actually think this is a good candidate for google/react-schemaorg, which wraps this library with convenience React-specific functions. Helmet's innerHTML can be dangerous, e.g. a string can contain '</script>', and that library takes care of serializing/escaping the JSON-LD per the standard. |
Oh wow! I did not know there was a react wrapper... |
Yeah, I'll do that soon. The standard |
Although quite trivial afterwards, it took me quite a while to figure out how to use this library with react-helmet.
You might consider updating the docs if not, feel free to close this.
The text was updated successfully, but these errors were encountered: