-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename .storybook folder to have no dots in the prefix #10090
Comments
@eugene-manuilov wouldn't the storybook config go into the root of a new workspace for Storybook under the same name? |
@aaemnnosttv, yes, good point, but that should happen in #10091 |
@eugene-manuilov what I meant was, this change doesn't seem necessary if we are putting this into the new workspace rather than trying to make it the workspace itself. Could we not create |
Not sure what you suggest, @aaemnnosttv. We have some storybook dependencies (one of which is puppeteer iirc) that would be nice to move to its own workspace. Do you suggest not creating a workspace for storybook and leave them in the main package.json file? |
@aaemnnosttv could you please take a look at this ticket today? It is blocking all other tickets. Thank you. |
@ivonac4 it blocks only #10091, other tasks to move js deps should be good to go. |
@eugene-manuilov yes, but then 10091 blocks other 2 tickets. |
@eugene-manuilov if we need to do this it's fine, it just seems potentially unnecessary if we did it at the same time as #10091. This would result in a directory structure like |
IB ✅ |
Feature Description
In order to prepare storybook dependencies to migrated into their own workspace, we need to rename the main folder we use for the storybook setup. This is needed because we can't use workspaces that start with dots. So, ideally, we need to rename
.storybook
to be juststorybook
.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
.storybook
folder is renamed tostorybook
..storybook
folder in our codebase (if we have any) are updated to point to the new folder.Implementation Brief
.storybook
folder tostorybook
..storybook/
:Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: