Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPML Compatibility: switching language from top admin bar disconnects and prompts setup #2118

Closed
ernee opened this issue Oct 1, 2020 · 29 comments
Labels
Type: Bug Something isn't working

Comments

@ernee
Copy link

ernee commented Oct 1, 2020

Bug Description

When using the WPML plugin, switching languages from the top admin bar disconnects Site Kit and prompts the setup process due to detecting a change in the URL:

notice to reconnect after change in URL

Steps to reproduce

  1. Install and configure the WPML plugin
  2. Change the language selection from the top admin bar
  3. See Site Kit disconnect and notice to reconnect appear

Additional Context

  • PHP Version: 7.3.16
  • OS: MacOS
  • Browser: Chrome
  • Plugin Version: 1.17.0
  • Device: MacBook Air

Video: https://recordit.co/vLmmvjusME

Related support topics:

https://wordpress.org/support/topic/site-kit-asks-me-to-reconnect-all-the-time/
https://wordpress.org/support/topic/site-kit-asks-me-to-be-reconnected-when-change-language-flag-wpml/
https://wordpress.org/support/topic/wpml-issue-17/


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

Visual Regression Changes

QA Brief

Changelog entry

@ernee ernee added the Type: Bug Something isn't working label Oct 1, 2020
@Nerdiyde
Copy link

Nerdiyde commented Oct 4, 2020

Hey Guys, i have the same issue. I'm not using WPML but WPGlobus. Just wanted to let you know. :)

@joecarletto
Copy link

Hi guys, I've the same bug and I'm using WPML

@xanxano
Copy link

xanxano commented Oct 4, 2020

Hi!
The same thing, wpml with one domain per language...
We are waiting for the updates! ;-)

@adamsilverstein
Copy link
Collaborator

Thanks for the feedback @xanxano, @joecarletto & @Nerdiyde. We are working to address this issue in #2131.

@ernee
Copy link
Author

ernee commented Oct 13, 2020

Hi there! Just a quick update that we'll be reaching out to multilingual plugins to help with the solution.

@Nerdiyde I've been trying to recreate the issue with WPGlobus, but have yet to see it occur. Could you share more about your configuration and how to reproduce the issue? Thanks so much!

@Nerdiyde
Copy link

@ernee Hey,
hmm, I did not really do anything special to provoke this error. :/ Not even sure that the issue is related to WPGlobus. Just mentioned it because others mentioned WPML as a possible source. Maybe its related to an other plugin? Please tell me what other information might be helpful? :) Thanks for fixing this btw. :)

@ernee
Copy link
Author

ernee commented Oct 13, 2020

@Nerdiyde thanks for the reply! It would be great to get more info about your setup. Could you provide your Site Health information through this form (note: you may want to place the support forum topic you replied to in the corresponding field)?

@Nerdiyde
Copy link

@ernee You should have received my site health infos. :)

@ernee
Copy link
Author

ernee commented Oct 16, 2020

@Nerdiyde thanks for providing the info! So, I've been testing your theme, several plugins you have, and some configurations but haven't been able to recreate the issue you experienced. Could you provide/ try the following to help us narrow down what could be the source of the issue on your site:

  1. It doesn't seem like one can switch the WP admin languages in WPGlobus when you have selected a site language and user language in the WordPress settings (in your case it is German - DE). Do you recall a particular action that causes Site Kit to disconnect?

  2. Could you use the Health Check & Troubleshooting plugin and enable its troubleshooting mode. This mode disables active plugins and switches to a default theme safely since it only affects the experience of the logged-in user.

@hifi-vd
Copy link

hifi-vd commented Oct 17, 2020

Hi, I have the same problem with very often reconnecting Site Kit and using WPML. I am using Google Tag Manager as connector for Google access codes. Before the codes were in the templates and I had no problem. But with every update of the templates I lost access, so changed to Tag Manager. It would be fine to solve this "reconnect" problem, because WPML and Tag Manager are great and very common tools. Thanks

@ered15
Copy link

ered15 commented Oct 19, 2020

Having same issue, have the last WP installation and using Site Kit by Google 1.18.0, WPML Version 4.4.3 every time I change the language in the top bar it asks to reconnect.

@ernee
Copy link
Author

ernee commented Oct 28, 2020

Thanks @hifi-vd and @ered15 for reporting! We've reached out to the team at WPML to help with a fix. We'll keep this issue updated on the progress.

@Rescovedo
Copy link

Finally found my friends with the same issue <3

@LCthur
Copy link

LCthur commented Nov 5, 2020

Hey guys, I'm using WPML and I have the same problem.

@adamsilverstein
Copy link
Collaborator

Hi everyone, thanks for your patience while we worked on a solution for this. We added a filter into Site Kit and are working with WPML to ensure we are compatible. For full compatibility, you will need to be using the latest version of Site Kit and the next version of WPML - the fix should go out with WPML 4.4.5 (next release).

@joecarletto
Copy link

Well done, @adamsilverstein!

@adamsilverstein
Copy link
Collaborator

👋 Hello reporters - the new WPML version updated has started rolling out. When you have the new (WPML 4.4.5) version installed, can you please re-check Site Kit and ensure you correctly remain connected when switching languages?

@ernee
Copy link
Author

ernee commented Nov 14, 2020

Reported in this support topic, it appears the issue persists when selecting "All languages" from the top admin bar language switcher (Site Kit disconnects). Here is a video.

@adamsilverstein
Copy link
Collaborator

Thanks @ernee - I have contacted WPML about this issue and we will look into an appropriate fix.

@ernee
Copy link
Author

ernee commented Nov 27, 2020

WPML is planning to release the fix for the remaining issue in their next version 4.4.7. We'll follow up when it is available.

@SamManders
Copy link

I'm having the same issue, but I'm using TranslatePress. Seems like most translated sites suffer from this issue...
If there will be any solution I'd be happy to hear it.

@ernee
Copy link
Author

ernee commented Dec 7, 2020

WPML version 4.4.7 has just been released with the remaining fix to address the issue with the "All languages" admin bar setting.

@SamManders thanks for reporting. We've been trying to replicate the issue using TranslatePress. Could you send us a recording and/ or a detailed step-by-step of what causes the issue on your site? You can use an app like Recordit to make a video. Many thanks!

@ernee
Copy link
Author

ernee commented Dec 15, 2020

Closing this issue since it is resolved with WPML.

We have a few other multilingual plugins we'll be reaching out to as well. If you haven't already, please open a support topic if you are experiencing this issue with another plugin (not WPML).

@ernee ernee closed this as completed Dec 15, 2020
@Nerdiyde
Copy link

Nerdiyde commented Jan 5, 2021

Hey guys,
I did install the patch @adamsilverstein provided. Thanks a lot for your work! :)
Do you need anything as some kind of "success report"?
Thanks and best regards
Fab

@adamsilverstein
Copy link
Collaborator

Here is a "mini plugin" you can install if you are still experiencing an issue with your install: https://gist.github.com/adamsilverstein/199f3a4cfe8b4ccc881713a7ece05438

@jamesozzie
Copy link
Collaborator

@Nerdiyde Great to hear it. We'll certainly keep you in mind should we be looking for user case studies or blog posts. If you haven't already done so we'd love to hear your feedback.

@vmajor
Copy link

vmajor commented Feb 23, 2021

Related issue, perhaps. I am using TranslatePress and keep getting disconnected. I will look for/make a separate issue for this.

@adamsilverstein
Copy link
Collaborator

@vmajor Thanks for your comment.

I have reported this issue to translatepress support and opened the following issue to help improve the compatibility with Site Kit: phpzio/translatepress#4. Can you please link to or comment on this issue for visibility?

@jamesozzie
Copy link
Collaborator

@vmajor Just to let you know TranslatePress have made updates to their plugin to ensure Site Kit users remain connected. If you have any further queries on this feel free to reach out via the Site Kit WordPress support forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests