Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade npm dependency #2911

Closed
ivankruchkoff opened this issue Mar 2, 2021 · 1 comment
Closed

Upgrade npm dependency #2911

ivankruchkoff opened this issue Mar 2, 2021 · 1 comment
Labels
P2 Low priority Type: Infrastructure Engineering infrastructure & tooling

Comments

@ivankruchkoff
Copy link
Contributor

Feature Description

Our package-lock.json lockfileVersion is at version 1, ( see https://raw.githubusercontent.com/google/site-kit-wp/develop/package-lock.json "lockfileVersion": 1, ).

Our .nvmrc specifies node 14 but doesn't specify a version of npm. NPM 6 is bundled with the release, but there's nothing stopping you from doing npm i -g npm@7

NPM v7 has an updated package lockfile version https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json/#lockfileversion

Running different versions of npm (even if it's the same version of node) creates big changes with every npm install.

We can solve this by doing one of the following:

We can do one of the following to standardise on npm7:

  1. Introduce npm7 via config and also make it a point to upgrade our package-lock and reject CRs with lockfile version 1. OR
  2. Bump node version to node 15 which includes npm7. This seems like the easier/more consistent option.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

Visual Regression Changes

QA Brief

Changelog entry

@aaemnnosttv aaemnnosttv added P2 Low priority Type: Infrastructure Engineering infrastructure & tooling labels Apr 13, 2021
@aaemnnosttv aaemnnosttv self-assigned this Jul 16, 2021
@aaemnnosttv
Copy link
Collaborator

Closing in favor of #6026

@aaemnnosttv aaemnnosttv closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@aaemnnosttv aaemnnosttv removed their assignment Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

2 participants