Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of deprecated commands in GitHub actions #6104

Closed
aaemnnosttv opened this issue Nov 3, 2022 · 3 comments
Closed

Update usage of deprecated commands in GitHub actions #6104

aaemnnosttv opened this issue Nov 3, 2022 · 3 comments
Labels
P1 Medium priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Nov 3, 2022

Bug Description

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This also applies to dependencies that need upgrading in some cases.

For example, the GitHub actions/cache@v2 action raises these deprecation messages as well. See actions/cache#953

The fix for this only seems to exist in the newer v3 of the action, so we should upgrade to that.

These commands will stop working as of June 1st, 2023

Screenshots

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • All usage of the deprecated save-state and set-output commands in GitHub actions should be updated to use non-deprecated methods (more information)
    • This includes upgrading any actions as needed

Implementation Brief

  • Update the ".yml" files in .github/workflows to
    • use actions/cache@v3 instead of actions/cache@v2
    • replace set-output and save-state (if any) as per the docs.

Test Coverage

  • N/A

QA Brief

QA:Eng

  • Check the PR and make sure there's no deprecation warnings related to commands.
  • Once merged, also check the tests on the merge commit to make sure everything is ok.

Changelog entry

  • N/A.
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling labels Nov 3, 2022
@asvinb asvinb assigned asvinb and unassigned asvinb Nov 4, 2022
@eugene-manuilov eugene-manuilov self-assigned this Nov 17, 2022
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Nov 17, 2022
@kuasha420 kuasha420 self-assigned this Nov 21, 2022
@kuasha420 kuasha420 removed their assignment Nov 22, 2022
@techanvil techanvil assigned techanvil and unassigned techanvil Nov 22, 2022
techanvil added a commit that referenced this issue Nov 22, 2022
…ted-commands

Refactor GitHub Actions Deprecated Commands
@techanvil techanvil added the QA: Eng Requires specialized QA by an engineer label Nov 22, 2022
@techanvil
Copy link
Collaborator

@kuasha420, apologies but I've merged this without spotting an indentation error, which is now preventing the workflow from running on develop, see https://github.com/google/site-kit-wp/pull/6190/files#r1029288649

Please could you file a followup PR to address this?

@kuasha420 kuasha420 assigned techanvil and unassigned kuasha420 Nov 22, 2022
techanvil added a commit that referenced this issue Nov 22, 2022
Fix wrong indentation on a workflow.
@techanvil techanvil assigned techanvil and unassigned techanvil Nov 22, 2022
@techanvil
Copy link
Collaborator

techanvil commented Nov 25, 2022

QA ✅

  • Confirmed that deprecated save-state and set-output warnings are no longer occurring since merging this to develop.
  • For example here's the E2E (WordPress 5.2, AMP 1.x) workflow before and after:

Before:
image

image

After:
image

image

@techanvil techanvil removed their assignment Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

5 participants