From b0843cfe609fe6597dac0025dc70f051fec45608 Mon Sep 17 00:00:00 2001 From: William Candillon Date: Tue, 21 Oct 2025 15:00:21 +0200 Subject: [PATCH] =?UTF-8?q?fix(=F0=9F=A4=96):=20disable=20the=20optional?= =?UTF-8?q?=20PartitionAlloc=20dependency=20for=20Android?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We are unable to link Skia Graphite on Android if `dawn_partition_alloc_dir` is set. We also were unable to unset it via the command line. See discussion at https://groups.google.com/g/dawn-graphics/c/3GM3ZNKzFv0 --- build_overrides/dawn.gni | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build_overrides/dawn.gni b/build_overrides/dawn.gni index d7928b28e25b..512ffe1e7acc 100644 --- a/build_overrides/dawn.gni +++ b/build_overrides/dawn.gni @@ -25,8 +25,9 @@ dawn_wasm = false # PartitionAlloc is an optional dependency: # - MSVC compiler is not fully supported at the moment. # - Mac 11 is currently failing an assertion. +# - Android doesn't link properly # TODO(351867706): Enable Mac 11. _is_msvc = is_win && !is_clang -if (!_is_msvc && !is_mac) { +if (!_is_msvc && !is_mac && !is_android) { dawn_partition_alloc_dir = "//third_party/externals/partition_alloc" }