BySelector.copy becomes erroneous due to shallow copy.

[TranquilRock]

LOC related

Reproduction:

import mock
from snippet_uiautomator import uidevice

ui_device = uidevice.UiDevice(ui=mock.MagicMock())

root = ui_device(res='root')
view_group = root.child(clazz='android.view.ViewGroup')
# view_group._selector.to_dict() ==
# {'res':'root', 'child': {'clazz' : 'android.view.ViewGroup'}}

for i in range(3):
  ith_desc = view_group.children[i]['contentDescriptions']
  ith = view_group.child(desc=ith_desc)  # This change the view_group._selector
  # view_group._selector.to_dict() == ith._selector.to_dict() ==
  # {'res':'root', 'child': {'clazz' : 'android.view.ViewGroup', 'child': {'desc': ''}}}

Should we change to BySelector(copy.deepcopy(**self._selector) instead of BySelector(**self._selector)?

[ko1in1u]

Good catch! Yes, we should deep copy the dict.