Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Auto-Reload on config change #211

Open
ameukam opened this issue Sep 15, 2020 · 2 comments
Open

FR: Auto-Reload on config change #211

ameukam opened this issue Sep 15, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ameukam
Copy link

ameukam commented Sep 15, 2020

It would great if triage-party can automatically reload whenever the ConfigMap is modified so that the pod doesn't need to be deleted and re-created.

@tstromberg tstromberg changed the title FR: Auto-Reload on configmap change FR: Auto-Reload on config change Oct 6, 2020
@tstromberg
Copy link
Collaborator

Great idea. I think we can make this general enough so that it auto-reloads if the config file changes -- as config maps are seen as a flat file to Triage Party.

@tstromberg tstromberg added enhancement New feature or request help wanted Extra attention is needed labels Oct 6, 2020
@eddiezane
Copy link
Contributor

I took a look at this and I think there are two things to solve for here.

  1. Determine when the config changes.

This appears to be pretty easy. We can take a similar approach to what Caddy did with watching for the file modification time. Another option is to use fsnotify.

  1. Reload the application.

This looks more challenging and will require a bit of rework in the main server function and control logic for the goroutines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants