Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Proc JIT should rely on Package less #1675

Open
grebe opened this issue Oct 30, 2024 · 0 comments
Open

[enhancement] Proc JIT should rely on Package less #1675

grebe opened this issue Oct 30, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request jit

Comments

@grebe
Copy link
Collaborator

grebe commented Oct 30, 2024

What's hard to do? (limit 100 words)

Constructing an AOT proc wrapper can be slow because it needs to parse the package for relevant metadata. Until recently, this was also true for function and block AOT wrappers, but I recently landed a change that allows those wrappers to only use protos that describe the interface for relevant metadata. The proc jit relies more on this metadata, e.g. for managing the queues, so I didn't do the same thing for the AOT proc wrapper.

Current best alternative workaround (limit 100 words)

Accept that constructing a AOT proc wrapper is slow. Reuse a singleton proc wrapper (getting new continuations from a common wrapper instead of constructing a new wrapper each time).

Your view of the "best case XLS enhancement" (limit 100 words)

The proc jit will be the same as the function+block jits in that it doesn't have enduring hooks into Package metadata.

@grebe grebe added the enhancement New feature or request label Oct 30, 2024
@grebe grebe added the jit label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jit
Projects
None yet
Development

No branches or pull requests

2 participants