Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tvOS BasicExample Objective-C project does not compile out of the box #7

Open
jrtibbetts opened this issue Jul 20, 2020 · 1 comment

Comments

@jrtibbetts
Copy link

Neither the Objective-C nor Swift BasicExample projects compile as-is. This ticket will focus on the tvOS-specific issues.

  1. No Podfile is included.

  2. The sample app target (9.2) is lower than the minimum OS version (10.0) the current SDK (4.2.3) requires.

  3. Adding a Podfile that contains only

    source 'https://github.com/CocoaPods/Specs.git'
    
    platform :tvos, '9.2'
    
    target "BasicExample" do
      pod 'GoogleAds-IMA-tvOS-SDK'
    end
    

    fails to compile with the following errors:

    • ObjectiveC/BasicExample/app/ViewController.m:99:60: No visible @interface for 'IMAAdDisplayContainer' declares the selector 'initWithAdContainer:viewController:'
    • ObjectiveC/BasicExample/app/ViewController.m:122:39: Property 'focusEnvironment' not found on object of type 'IMAAdDisplayContainer *'
    • ObjectiveC/BasicExample/app/ViewController.m:153:10: Use of undeclared identifier 'kIMAAdEvent_ICON_FALLBACK_IMAGE_CLOSED'
@jrtibbetts
Copy link
Author

ObjectiveC/BasicExample/app/ViewController.m:99:60: No visible @interface for 'IMAAdDisplayContainer' declares the selector 'initWithAdContainer:viewController:

can be fixed by dropping the second argument.

ObjectiveC/BasicExample/app/ViewController.m:122:39: Property 'focusEnvironment' not found on object of type 'IMAAdDisplayContainer *'

I don't see a reasonable replacement for this. (Incidentally, this is related to the problem we're having that led me try the BasicExample app in the first place--the Google IMA player often ignores play/pause presses, or play/pause presses get ignored by our player after a Google IMA ad has finished playing. If an ad never played, then our player receives the presses as expected.)

ObjectiveC/BasicExample/app/ViewController.m:153:10: Use of undeclared identifier 'kIMAAdEvent_ICON_FALLBACK_IMAGE_CLOSED'

can perhaps be removed entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant