consumption of method_signature annotation doesn't account for dot-notation access of nested fields for a required field #684
Labels
good first issue
This issue is a good place to started contributing to this repository.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
The following code:
gapic-generator-php/src/Generation/BuildMethodFragmentGenerator.php
Lines 135 to 141 in 277c703
Does not account for a signature like
"foo.a,foo.b"
wherefoo
is agoogle.api.field_behavior = REQUIRED
field. The presence offoo.a
should be sufficient.Furthermore, we need to make sure that
build
fragment generation can handle a dot-notation signature!The text was updated successfully, but these errors were encountered: