Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all Post Processing formatting to GAPIC generation / post processing #711

Open
bshaffer opened this issue May 9, 2024 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

bshaffer commented May 9, 2024

See googleapis/synthtool#1415

We are currently running the NodeJS prettier plugin as part of owlbot.py, which for obvious reasons is not ideal.

We are already using the symplify/coding-standard package to format the code in this library (see Formatter), so I'm not sure what additional formatting is even happening using the prettier plugin . We may be using it only for the line-lengths. And if that's the case, we should either format the line-lengths with another plugin, or decide that this is not an important enough change and remove it from owlbot post-processing all together.

@bshaffer bshaffer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 9, 2024
@bshaffer
Copy link
Contributor Author

Doing this should also resolve googleapis/google-cloud-php#6785, or at the very least make it easier to track down changes like that, as they'll only happen in one place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant