Reduce code duplication in method signatures throughout the code base #2254
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
See the diff in PR https://github.com/googleapis/gapic-generator-python/pull/2253/files which shows changes to the following code which appears throughout the code base
We can reduce code duplication by using common code for a common method signature. As a pre-requisite, we need to fix the following issues
Address the inconsistency with the default values in timeout.
See here
gapic-generator-python/gapic/templates/%namespace/%name_%version/%sub/services/%service/_client_macros.j2
Lines 31 to 32 in 515dc8a
and here
gapic-generator-python/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2
Line 205 in 515dc8a
Address the inconsistency in the type for Async REST and Async Mixins and pagers, where we have both
OptionalAsyncRetry
andOptionalRetry
defined as the type forretry
See here
gapic-generator-python/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest_asyncio.py.j2
Line 62 in 515dc8a
and here
gapic-generator-python/gapic/templates/%namespace/%name_%version/%sub/services/%service/_async_mixins.py.j2
Line 10 in 515dc8a
and here
OptionalAsyncRetry
gapic-generator-python/gapic/templates/%namespace/%name_%version/%sub/services/%service/pagers.py.j2
Line 16 in 515dc8a
The text was updated successfully, but these errors were encountered: