From ea426f81a0bf4ad8d2d7e4ebdc59f9a496e697af Mon Sep 17 00:00:00 2001 From: Amanda Tarafa Mas Date: Thu, 7 Sep 2023 22:08:16 -0700 Subject: [PATCH 1/2] chore: Remove stale comment --- .kokoro/autorelease.sh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.kokoro/autorelease.sh b/.kokoro/autorelease.sh index f71363f50ba..ee8bb0f030b 100644 --- a/.kokoro/autorelease.sh +++ b/.kokoro/autorelease.sh @@ -72,10 +72,6 @@ rm -f DiscoveryJson/datalineage_v1.json rm -f DiscoveryJson/policysimulator_v1alpha.json rm -f DiscoveryJson/policysimulator_v1beta.json -# Note the space on the parameter definition and not on command -# execution itself: this is because if there's a space, then on -# some environments, a second empty parameter is passed to -# BuildGenerated.sh and that makes it fail. if [ "$FORCE_ALL" == "true" ]; then ./BuildGenerated.sh --skipdownload --forcegenerateall else From b359be2d8435da0c100cb038daa1343369b69a8d Mon Sep 17 00:00:00 2001 From: Amanda Tarafa Mas Date: Thu, 7 Sep 2023 22:53:14 -0700 Subject: [PATCH 2/2] chore: Update the list of APIs that we skip for Discovery based libraries generation. --- .kokoro/autorelease.sh | 36 +++++++++++++----------------------- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/.kokoro/autorelease.sh b/.kokoro/autorelease.sh index ee8bb0f030b..d8988e837b2 100644 --- a/.kokoro/autorelease.sh +++ b/.kokoro/autorelease.sh @@ -34,41 +34,31 @@ git config user.email "$github_email" # Delete broken discovery docs here. # E.g. rm -f DiscoveryJson/streetviewpublish_v1.json -# These have nested resources with the same type as the parent +# For more details go/dotnet-apiary-blocked-generation + +# b/299933892 because of hierarchical resources +# "nodes/{node}/nodes/{node}" rm -f DiscoveryJson/sasportal_v1alpha1.json rm -f DiscoveryJson/prod_tt_sasportal_v1alpha1.json +# Known exception for library generation rm -f DiscoveryJson/apigee_v1.json -# The following 3 have a Service named parameter in a request -# that clashes with our own IClientService Service property -# that we have in BaseServiceRequest +# Name clashes because of some request's service parameter. rm -f DiscoveryJson/metastore_v1alpha.json rm -f DiscoveryJson/metastore_v1beta.json rm -f DiscoveryJson/metastore_v1.json -# b/238627322 -rm -f DiscoveryJson/monitoring_v1.json -# We've only generated identitytoolkit_v3 during 2013 and 2014. -# After that it was skipped for generation and the package delisted. -# v1 and v2 were introduced in August 2022 and v1 was broken. -# As of 20221018, v1 has nested resources or methods with the same name -# but v2 and v3 generate and build fine. -# That Auth team is looking into whether we should generate v2 and v3. +# Investigating with Auth team rm -f DiscoveryJson/identitytoolkit_v1.json rm -f DiscoveryJson/identitytoolkit_v2.json rm -f DiscoveryJson/identitytoolkit_v3.json -# There's a response type that itself represents and HTTP response -# and includes an ETag property whose value is the Etag for the -# response that it represents and not its own. The type ends having -# two ETag properties. +# Name clashes because of some response ETag field. rm -f DiscoveryJson/contentwarehouse_v1.json -# TODO[atarafamas] find out why +# b/299569133 method.request.type instead of method.request.$ref +# type is not a supported field in method.request. rm -f DiscoveryJson/integrations_v1alpha.json -# TODO[atarafamas] find out why +# b/299567447 method.request.type instead of method.request.$ref +# type is not a supported field in method.request. rm -f DiscoveryJson/datalineage_v1.json - -# This causes a failure of -# error CS0102: The type 'OrganizationsResource.LocationsResource' -# already contains a definition for 'OrgPolicyViolationsPreviews' -# TODO[atarafamas] work out what to do about it +# b/299985033 Because on non-AIP compliant RPC. rm -f DiscoveryJson/policysimulator_v1alpha.json rm -f DiscoveryJson/policysimulator_v1beta.json