HttpMockSequence is missing close() method #2359
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
google-api-python-client
version: Version: 2.122.0Steps to reproduce
Code example
Using build in a context manager is recommended by https://github.com/googleapis/google-api-python-client/blob/main/docs/start.md to ensure that service (and underlying http resources) are cleaned up.
Httplib2 has close() method that was added ~5 years ago.
Stack trace
I think HttpMockSequence is just missing the close() method. TBH I just started using this library, but after a bunch of searching I think I'm using it as recommended, and I'm surprised that I'm the first to stumbled across this / report this.
Thanks for any help, and I'm happy to send a PR fixing the issue.
The text was updated successfully, but these errors were encountered: