Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove envDetect.ts and utilize gcp-metatada's utilities #1674

Open
danielbankhead opened this issue Oct 12, 2023 · 0 comments
Open

refactor!: Remove envDetect.ts and utilize gcp-metatada's utilities #1674

danielbankhead opened this issue Oct 12, 2023 · 0 comments
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Member

gcp-metadata has built-in environment capabilities that we should utilize.

Additionally, customers can use gcp-metadata as of:
@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. semver: major Hint for users that this is an API breaking change. good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version Breaking Change labels Oct 12, 2023
@danielbankhead danielbankhead removed their assignment Oct 13, 2023
@danielbankhead danielbankhead changed the title refactor!: Remove envDetect.ts and utilize in favor of gcp-metatada's utilities refactor!: Remove envDetect.ts and utilize gcp-metatada's utilities Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielbankhead