Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove Transporter and DefaultTransporter from GoogleAuth class #1687

Open
danielbankhead opened this issue Nov 2, 2023 · 2 comments · May be fixed by #1688
Open

refactor!: Remove Transporter and DefaultTransporter from GoogleAuth class #1687

danielbankhead opened this issue Nov 2, 2023 · 2 comments · May be fixed by #1688
Assignees
@Dhoni77
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Member

These properties are unused and can be confusing for customers if they are set.
@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. semver: major Hint for users that this is an API breaking change. good first issue This issue is a good place to started contributing to this repository. Breaking Change priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 2, 2023
@Dhoni77
Copy link

Dhoni77 commented Nov 3, 2023

Hi I would like to work on this

@danielbankhead
Copy link
Member Author

@Dhoni77 Thanks! Assigned. Take your time as this refactor is a breaking change and we won’t release another major for some time.

@Dhoni77 Dhoni77 linked a pull request Nov 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dhoni77 Dhoni77

Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
2 participants
@danielbankhead @Dhoni77