fix(pubsub): move start span logic for publish batch #11193
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
duongcongtoai
changed the title
duongcongtoai
force-pushed
the
fix-mem-leak-in-tracing
branch
from
c692d21
to
2c8d48c
Compare
duongcongtoai
changed the title
hongalex
approved these changes
Dec 2, 2024
kokoro-team
removed
the
kokoro:run
hongalex
added
automerge
kokoro-team
removed
the
kokoro:force-run
hongalex
changed the title
kokoro-team
removed
the
kokoro:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #11186
Having this span started while tracing is disabled do not directly cause memory leak, but if otel sdk is used together with other sdk such as sentry (which internally store a global map of otel span ID -> sentry span ID), if the span never ends the entries in this map is never GCed, and thus all the span object that they refers to never get GCed