-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing customVoice in dialogflow.VoiceSelectionParams #5903
Comments
Hi @orgads, I see it in the protos now, could you give this a try again? As an FYI, our REST API (the documentation you linked) isn't always the same as the version in this library - it actually corresponds to google-api-nodejs-client. They are independent, so there's no guarantee of parity or, if there is, not necessarily temporal parity. Sometimes it's just worth waiting a bit, and if you don't see it (and there aren't any PRs that need to be merged on the repo), it could be worth requesting it to the API itself in the issue tracker, since it means they haven't made that feature available in the grpc library. |
Where do you see it? The linked doc still doesn't have it, and the node client version 6.13.0 still misses it. Is it possible to move the issue to the api project? |
I see it in the protos.d.ts (can't link it on Github since the page is too large to view on GH). I do notice that 6.14 was only released 7 days ago so maybe we just hadn't released that version. Apologies I forgot to check if it had been released - can you retry now? |
It's still not there. Here are lines 50567-50574 of version 6.14.0: interface IVoiceSelectionParams {
/** VoiceSelectionParams name */
name?: (string|null);
/** VoiceSelectionParams ssmlGender */
ssmlGender?: (google.cloud.dialogflow.v2beta1.SsmlVoiceGender|keyof typeof google.cloud.dialogflow.v2beta1.SsmlVoiceGender|null);
} |
Please make sure you have searched for information in the following guides.
A screenshot that you have tested with "Try this API".
N/A
Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.
https://gist.github.com/orgads/9af03eaa5db52728955de168bdc014bc
A step-by-step description of how to reproduce the issue, based on the linked reproduction.
Just try to build this file with Typescript, and it fails.
Object literal may only specify known properties, and 'customVoice' does not exist in type 'IVoiceSelectionParams'.ts(2353)
A clear and concise description of what the bug is, and what you expected to happen.
VoiceSelectionParams
should containcustomVoice
, as it does intext-to-speech
, documented here. This is missing in dialogflow, documented here.A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **
It is supported in the private CCAI dialogflow library. IIRC this is the only notable change (at least for what we use) between the official and the private sdk.
The text was updated successfully, but these errors were encountered: