Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java does unnecessary boxing #3459

Open
cushon opened this issue Aug 27, 2024 · 0 comments · May be fixed by #3460
Open

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java does unnecessary boxing #3459

cushon opened this issue Aug 27, 2024 · 0 comments · May be fixed by #3460
Assignees
@PhongChuong
Labels
api: bigquery Issues related to the googleapis/java-bigquery API.

Comments

@cushon
Copy link
Contributor

cushon commented Aug 27, 2024

This line is unnecessarily using a boxed Long instead of a long:

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java

Line 42 in 421c825

public abstract TableResult.Builder setTotalRows(Long totalRows);

Future version of AutoValue report a diagnostic for this issue: google/auto@328a25c
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Aug 27, 2024
@cushon cushon linked a pull request Aug 27, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhongChuong PhongChuong

Labels
api: bigquery Issues related to the googleapis/java-bigquery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unnecessary boxed primitives in AutoValue classes cushon/java-bigquery
2 participants
@cushon @PhongChuong