Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Support fire-admin tag for Admin Node SDK #2238

Merged
merged 5 commits into from
Dec 5, 2024
Merged

chore: Support fire-admin tag for Admin Node SDK #2238

merged 5 commits into from
Dec 5, 2024

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Nov 27, 2024 •
edited
Loading

This PR allows the Admin Node SDK to pass its version and append the fire-admin tag to the existing x-goog-api-client header.

Example: fire-admin/13.0.1

@jonathanedey jonathanedey requested review from a team as code owners November 27, 2024 14:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Nov 27, 2024
@ehsannas ehsannas added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024
@jonathanedey jonathanedey mentioned this pull request Dec 2, 2024
Merged
@MarkDuckworth MarkDuckworth added the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@MarkDuckworth MarkDuckworth added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 3, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@MarkDuckworth MarkDuckworth added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2024
@MarkDuckworth MarkDuckworth added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:ignore instruct owl-bot to ignore a PR labels Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@MarkDuckworth MarkDuckworth added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Dec 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2024
@MarkDuckworth MarkDuckworth added owlbot:ignore instruct owl-bot to ignore a PR owl-bot-update-lock and removed owlbot:ignore instruct owl-bot to ignore a PR owl-bot-update-lock labels Dec 4, 2024
@MarkDuckworth MarkDuckworth changed the base branch from main to markduckworth/fire-admin December 5, 2024 00:21
@MarkDuckworth MarkDuckworth merged commit 5854a1f into googleapis:markduckworth/fire-admin Dec 5, 2024
13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 5, 2024
@MarkDuckworth MarkDuckworth mentioned this pull request Dec 5, 2024
Merged
MarkDuckworth added a commit that referenced this pull request Dec 5, 2024
@MarkDuckworth @jonathanedey
feat: Support fire-admin tag for Admin Node SDK (#2238) (#2252)
1339dc2 
Co-authored-by: Jonathan Edey <[email protected]>
@release-please release-please bot mentioned this pull request Dec 4, 2024
Merged
@jonathanedey jonathanedey deleted the je-fire-admin-tag branch December 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanedey @MarkDuckworth @ehsannas @yoshi-kokoro