Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AuthClient for auth #453

Open
danielbankhead opened this issue Mar 16, 2022 · 1 comment
Open

Support AuthClient for auth #453

danielbankhead opened this issue Mar 16, 2022 · 1 comment
Assignees
@sofisl
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@danielbankhead
Copy link
Contributor

Currently the standard auth parameter uses an explicit list of clients that extend AuthClient:

auth?:
      | string
      | OAuth2Client
      | JWT
      | Compute
      | UserRefreshClient
      | BaseExternalAccountClient
      | GoogleAuth;

Src: https://github.com/googleapis/google-api-nodejs-client/blob/main/src/apis/abusiveexperiencereport/v1.ts#L48-L55

In order to support new clients, such as DownscopedClient, auth can be simplified to:

auth?: string | AuthClient | GoogleAuth;

Related:
@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 16, 2022
@danielbankhead
Copy link
Contributor Author

Here's a permalink:

https://github.com/googleapis/google-api-nodejs-client/blob/9a80a59df4a882bfca09a19f30556ef05772488a/src/apis/abusiveexperiencereport/v1.ts#L47-L54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielbankhead @sofisl