Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for proxies please! #396

Open
pierznewton-john opened this issue Aug 9, 2024 · 3 comments
Open

Support for proxies please! #396

pierznewton-john opened this issue Aug 9, 2024 · 3 comments
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@pierznewton-john
Copy link

Is your feature request related to a problem? Please describe.
The library does not work behind a proxy. This is because it uses node's in-built fetch function to post to Vertex, and fetch has no proxy support.

Describe the solution you'd like
Please use something other than fetch to call the Vertex and allow for proxy support in some way, such as a proxy config object being passed in to the VertexAI constructor (I have not through through the most appropriate way to configure the proxy settings). Note that GCP CLI supports this, so it seems odd that this library does not. It's critical to our use case so I will need to fork the SDK to be able to use it.

Describe alternatives you've considered
There are no alternatives. We can't use the SDK without this feature.

@pierznewton-john pierznewton-john added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 9, 2024
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Aug 9, 2024
@happy-qiao
Copy link
Collaborator

@pierznewton-john
Thank you for your feedback on using proxies. To help us prioritize the development of proxy-related features, could you please share more about your specific use case? Understanding how you use proxies—whether for security, performance optimization, bypassing restrictions, or other reasons—will allow us to better align our features with your needs.

@pierznewton-john
Copy link
Author

@happy-qiao
We are developing an API to extract data from customer documents in a loan application setting inside a major bank. For security reasons, we have to operate from behind the corporate proxy server.

@pierznewton-john
Copy link
Author

BTW I am currently working around this issue by monkey-patching the global fetch function and using Axios in my replacement fetch method. Which is clearly butt ugly :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants