Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fileUris to contain HTTP URLs & YouTube urls #434

Open
fiws opened this issue Oct 2, 2024 · 0 comments
Open

Support fileUris to contain HTTP URLs & YouTube urls #434

fiws opened this issue Oct 2, 2024 · 0 comments
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@fiws
Copy link

fiws commented Oct 2, 2024

YouTube & HTTP URLs are supported according to the vertex-ai api: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/inference

But this package does some processing which only allows GCS URIs:

URIError: Found invalid Google Cloud Storage URI https://youtube.com/watch?v=dQw4w9WgXcQ, Google Cloud Storage URIs must start with gs://

https://github.com/googleapis/nodejs-vertexai/blob/main/src/functions/pre_fetch_processing.ts#L53
@fiws fiws added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 2, 2024
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fiws