Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hint for response parameter in format_http_response_error #691

Open
ohmayr opened this issue Sep 9, 2024 · 0 comments
Open

Add type hint for response parameter in format_http_response_error #691

ohmayr opened this issue Sep 9, 2024 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Sep 9, 2024

Add type hint for response parameter in format_http_response_error(response, method: str, url: str, payload: str = None) method to be Union[google.auth.transport.Response, google.auth.aio.transport.Response] to match the docstring.
@parthea parthea added the type: cleanup An internal cleanup or hygiene concern. label Sep 12, 2024
@parthea parthea removed their assignment Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @ohmayr