Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy issues #773

Closed
daniel-sanche opened this issue Oct 3, 2023 · 2 comments · May be fixed by #823
Closed

mypy issues #773

daniel-sanche opened this issue Oct 3, 2023 · 2 comments · May be fixed by #823
Assignees
@daniel-sanche
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Q3

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Oct 3, 2023 •
edited
Loading

Currently, mypy is just testing the google.cloud.firestore module, which is mostly empty. If changed to test google.cloud.firestore_v1, errors come up. We should resolve all typing issues with the library

One option is to completely wipe the type annotations and start fresh, slowly adding them back over time

Or, we can fix it one file at a time, as we touch different areas of the code
@daniel-sanche daniel-sanche added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 3, 2023
@daniel-sanche daniel-sanche self-assigned this Oct 3, 2023
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 3, 2023
@daniel-sanche daniel-sanche mentioned this issue Oct 6, 2023
Merged
4 tasks
This was referenced Oct 16, 2023
Merged
Closed
Draft
This was referenced Dec 12, 2023
Merged
Draft
@daniel-sanche daniel-sanche mentioned this issue Jan 12, 2024
Closed
@daniel-sanche daniel-sanche added this to the Q2 milestone Feb 23, 2024
@daniel-sanche daniel-sanche mentioned this issue Jun 17, 2024
Closed
@daniel-sanche daniel-sanche mentioned this issue Jul 31, 2024
Merged
21 tasks
@daniel-sanche
Copy link
Contributor Author

update: we are working on a couple new features, but this is a high priority item once those are in

@daniel-sanche daniel-sanche mentioned this issue Aug 6, 2024
Closed
@daniel-sanche daniel-sanche mentioned this issue Aug 13, 2024
Closed
@daniel-sanche daniel-sanche mentioned this issue Oct 7, 2024
Closed
@daniel-sanche daniel-sanche mentioned this issue Nov 19, 2024
Merged
@daniel-sanche
Copy link
Contributor Author

fixed in #984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Q3
Development

Successfully merging a pull request may close this issue.

[DRAFT] chore: revert type hints googleapis/python-firestore
1 participant
@daniel-sanche